Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable authentication on mobile devices #1151

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Enable authentication on mobile devices #1151

merged 1 commit into from
Sep 18, 2018

Conversation

chouseknecht
Copy link
Contributor

Fixes #1148

newswangerd
newswangerd reviewed Sep 18, 2018
View reviewed changes
galaxyui/src/app/app.component.ts Outdated
return i;
}

private optionallyAddLoginButtons(): void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can set mobileItem to hide items when PF is not in mobile mode.

             {
                 title: 'My Imports',
                 iconStyleClass: 'fa fa-upload',
                 url: '/my-imports',
                 mobileItem: true,
            },

@chouseknecht chouseknecht merged commit 64838f8 into ansible:devel Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newswangerd newswangerd newswangerd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chouseknecht @newswangerd