Remove old search metrics collection system. #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cutwater
requested changes
Nov 5, 2018
| # Metrics Settings | ||
| # ========================================================= | ||
|
|
||
| METRICS_ENABLED = True |
There was a problem hiding this comment.
I think we should keep METRICS_ENABLED setting and adopt it for new metrics implementation, so that InfluxDB service can be optional for development environment.
There was a problem hiding this comment.
Done. I renamed it to GALAXY_METRICS_ENABLED.
newswangerd
added a commit
to newswangerd/galaxy
that referenced
this pull request
Nov 5, 2018
* Remove old search metrics collection system. * update docs * Add option to disable metrics in backend. (cherry picked from commit 5ebe403)
newswangerd
added a commit
that referenced
this pull request
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for tracking search queries using prometheus (added in #989) because we are inserting metrics directly into influx rather than using Prometheus.