Render content blocks from database #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cutwater
commented
Nov 21, 2017
galaxy/main/models.py
Outdated
|
|
||
|
|
||
| class ContentBlock(BaseModel): | ||
| name = models.SlugField() |
There was a problem hiding this comment.
Make name fields unique.
cutwater
commented
Nov 21, 2017
galaxy/main/models.py
Outdated
| class ContentBlock(BaseModel): | ||
| name = models.SlugField() | ||
| title = models.CharField('title', max_length=256, blank=True) | ||
| image = models.CharField('image', max_length=256, blank=True) |
There was a problem hiding this comment.
Drop title and image fields
cutwater
commented
Nov 21, 2017
| $ ansible-galaxy install username.rolename | ||
| </pre> | ||
| </div> | ||
| {% contentblock main-downloads %} |
There was a problem hiding this comment.
Consider using single tag for rendering block content, e.g. {% contentblock main-downloads %}.
Content should be safe by default.
cutwater
commented
Nov 21, 2017
galaxy/templates/home_title.html
Outdated
| {% contentblock main-title %} | ||
| {{ contentblock.content | safe}} | ||
| {% endcontentblock %} |
* Import data along with creating ContentBlock database table in migration `0055_contentblock`. * Make ContentBlock.name field unique.
cutwater
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #156