Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive search #877

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Responsive search #877

merged 1 commit into from
Jul 17, 2018

Conversation

newswangerd
Copy link
Member

Fixes: #814

Large Screen:
screen shot 2018-07-13 at 9 51 30 am

Medium Screen:
screen shot 2018-07-13 at 9 51 47 am

Mobile:
screen shot 2018-07-13 at 9 57 51 am

@newswangerd newswangerd changed the base branch from devel to release/3.0.3 July 13, 2018 14:09
@chouseknecht
Copy link
Contributor

@newswangerd Please squash your commits. See the command git rebase -i HEAD~#, where # is the number of commits you want to squash. This will allow you to interactively squash the commits, and consolidate the commit messages.

@chouseknecht
Copy link
Contributor

@newswangerd Can you please review this with @trahman73. Maybe you can get with him in a bluejeans session, and see what his thoughts and suggestions might be for the mobile Search view.

@chouseknecht chouseknecht requested a review from trahman73 July 15, 2018 16:10
@trahman73
Copy link

Large and medium views look good. I would try left aligning everything (user icon, downloads, stars, etc.) for the mobile view. Under the Popular Tags, I would right align the gray badge counts to match the left margin of the blue tags.

@newswangerd
make list items responsive
e9c0e43 
fix content type box

Make tags responsive

improve spacing on namespace avatar

Correctly align relevance and import on large screens

Make numbers bolder

fix flex boxes on chrome and safari

Improve mobile

Align list items to be flush with right hand side of list.

Remove align: center for avatar and name on mobile.
@newswangerd newswangerd merged commit 81d0351 into ansible:release/3.0.3 Jul 17, 2018
@newswangerd newswangerd mentioned this pull request Jul 19, 2018
Merged
@newswangerd newswangerd deleted the responsive-search branch July 19, 2018 20:34
@newswangerd newswangerd mentioned this pull request Jul 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trahman73 trahman73 Awaiting requested review from trahman73

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newswangerd @chouseknecht @trahman73