Author detail extravaganza #910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fereing with other routes fix spacing
Fix docs logo
Refactor content detail header to look more like mockups.
Implement lazy loading
Merge release/3.0.3
Add python coverage reports
Currently all tests in galaxy are located inside app folder. And only common tests are exceptional. This patch moves tests/unit files into common/tests to have consistent test locations and easier searching. Signed-off-by: Ivan Remizov <iremizov@gmail.com>
In APBImporter class definition it's also defined MAX_TAGS_COUNT class-constant. But constants.MAX_TAGS_COUNT is used instead. The constant has the same value. So it looks like it's a lind of artifact of refactoring. It's better to rmove it to avoid confusion. Signed-off-by: Ivan Remizov <iremizov@gmail.com>
Tripple-doubleqoutes (`"""`) are used almost everewhere in this project. And they are PEP compliant. However there are few places where tripple-singlequotes (`'''`) are still used. This patch replaces quotes with correct ones (`"""` -> `'''`). Signed-off-by: Ivan Remizov <iremizov@gmail.com>
It appears that utils.html_decode is never used. This function looks very specific with lmited use-cases. It's not covered with tests also. So it's better to remove it entirely. Signed-off-by: Ivan Remizov <iremizov@gmail.com>
Signed-off-by: Ivan Remizov <iremizov@gmail.com>
Signed-off-by: Ivan Remizov <iremizov@gmail.com>
Signed-off-by: Ivan Remizov <iremizov@gmail.com>
get_view_name() function is not exported and it's not used in scope of module. Signed-off-by: Ivan Remizov <iremizov@gmail.com>
This patch adds documentation sections related to * running lint checks, * running unit and functional tests, * setting up code coverage, * adding pre-commit hook. Signed-off-by: Ivan Remizov <iremizov@gmail.com>
get_view_description() function is not exported and it's not used in scope of module. Signed-off-by: Ivan Remizov <iremizov@gmail.com>
galaxyui/package.json has MIT license, but all banners in this repo state that license is Apache-2. This patch fixes license field to be Apache-2. Signed-off-by: Ivan Remizov <iremizov@gmail.com>
…_name Remove unused base_views.get_view_name()
Remove unused utils.html_decode
Fix tripple quotes to match PEP
…onstant Remove unused APBImporter.MAX_TAGS_COUNT
…_description Remove unused base_views.get_view_description()
This patch add linter for shell scripts. It includes: * Makefile target `dev/shellcheck`, * checks for `scripts/**/*.sh`, * corrections for code that did not pass shellcheck, * travis integration. Signed-off-by: Ivan Remizov <iremizov@gmail.com>
Add linter for shell scripts
Fix license in galaxyui package.json
…ence Fix typo in .../content/content.service.spec.ts
Move common tests into common folder
Improve documentation
…blank-lines Enable no-consecutive-blank-lines rule
Enable prefer-for-of in tslint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #908 to release/3.0.3