add Ah role and other improvements #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-m-sullivan
force-pushed
the
ah_role
branch
from
97dfd8a
to
651c470
Compare
Tompage1994
requested changes
Jan 12, 2023
sean-m-sullivan
force-pushed
the
ah_role
branch
from
651c470
to
5c26d85
Compare
sean-m-sullivan
force-pushed
the
ah_role
branch
from
5c26d85
to
8908c95
Compare
sean-m-sullivan
force-pushed
the
ah_role
branch
from
8908c95
to
06c874b
Compare
Tompage1994
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add role module to add group roles. This will not be able to be assigned to group permissions until a bug is fixed in galaxy ng.
In addition some endpoints were moved in latest version
https://github.com/ansible/galaxy_ng/pull/1397/files
after testing all the changes beyond the module should be backward compatible, but do not fix any of the underlying issues with ee_namespace or repository modules that still need to be updated.
How should this be tested?
Automated tests