Add sync and index option on respective roles #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-m-sullivan
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds sync or index option on roles to conditionally sync or index. This is based around the fact that you can't index all remote repositories so if you call the index role it will cause issues if one of your repositories isn't registry.redhat.io.
I figure it makes sense to do the same thing with the sync role too since the user may not want to sync either.
How should this be tested?
Not sure how great it would be to add to CI for _index and _sync for EEs but it can be tested by calling the role with or without sync and index set as true as options of
ah_ee_registriesIs there a relevant Issue open for this?
resolves #167
Other Relevant info, PRs, etc