Add arg specs #245
Merged
Add arg specs #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll probably have to work through any issues so don't merge whilst this is failing, but once it's passed then we should be good to go. I suspect there will be a few bits where the argspec causes issues here so I'll need to resolve |
|
Realising now that changes to CI don't get reflected in PRs anymore because of the workflow. I've fixed the first issue but possibly worth approving this and I'll fix anything broken tomorrow |
|
The CI will never work because it's currently broken in main and the new way of running CI means changes to .github aren't used (i.e. it takes the pipeline code from main to run CI) |
|
Have raised #246 to fix CI not running against updated test cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add arg spec for all roles
How should this be tested?
CI
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc
related https://github.com/redhat-cop/controller_configuration/discussions/509