Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit #258

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Update pre-commit #258

merged 1 commit into from
Jun 26, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Update pre-commit

@github-actions github-actions bot force-pushed the create-pull-request/update-pre-commit branch 2 times, most recently from 3047c89 to c23aa03 Compare May 24, 2023 05:07
@github-actions github-actions bot force-pushed the create-pull-request/update-pre-commit branch from c23aa03 to b48cb90 Compare June 1, 2023 05:08
@github-actions github-actions bot force-pushed the create-pull-request/update-pre-commit branch 3 times, most recently from ee8b354 to 52758a7 Compare June 14, 2023 05:07
@github-actions github-actions bot force-pushed the create-pull-request/update-pre-commit branch from 52758a7 to 7fbe696 Compare June 23, 2023 05:02
@djdanielsson
Copy link
Contributor

we really need to try and figure out a way to test the pre-commit changes before merging them because sometimes they add lint rules and stuff that you would want to add the fix into this PR before merging or the next poor soul who does a PR fails lint no matter what they are changing

@sean-m-sullivan sean-m-sullivan merged commit 90e3c93 into devel Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-m-sullivan sean-m-sullivan sean-m-sullivan approved these changes

@rochacbruno rochacbruno rochacbruno approved these changes

Assignees
No one assigned
Labels
automated pr pre-commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djdanielsson @rochacbruno @sean-m-sullivan @branic