Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make galaxy.yml persistent and move out ansible.cfg #284

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

Tompage1994
Copy link
Contributor

@Tompage1994 Tompage1994 commented Aug 2, 2023

What does this PR do?

Makes galaxy.yml persistent and moves the template out of root. Also moves ansible.cfg from root.

This makes it installable from source

How should this be tested?

  1. Test we can install from source
  2. We will need to perform a release and ensure that the galaxy.yml remains in the repo with -devel appended to the version that's just been released. We need to also be sure that the galaxy.yml of the released version is correct

Is there a relevant Issue open for this?

resolves #280

Other Relevant info, PRs, etc

Required redhat-cop/ansible_collections_tooling#33 to be merged

@Tompage1994 Tompage1994 changed the title [WIP] test without ansible.cfg to see what breaks Test without ansible.cfg to see what breaks Aug 2, 2023
@Tompage1994
Copy link
Contributor Author

Tests will all be failing until redhat-cop/ansible_collections_tooling#33 is merged

@Tompage1994 Tompage1994 changed the title Test without ansible.cfg to see what breaks Make galaxy.yml persistent and move out ansible.cfg Aug 2, 2023
Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit 0cd14ac into ansible:devel Aug 2, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansible.cfg presence in root might break installation from repository
2 participants