Use pulp_ansible collection upload refactor #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for galaxyng ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
gerrod3
force-pushed
the
collection-upload-comp
branch
4 times, most recently
from
47aeb58
to
ac51d20
Compare
gerrod3
force-pushed
the
collection-upload-comp
branch
from
ac51d20
to
e7fa39f
Compare
gerrod3
force-pushed
the
collection-upload-comp
branch
from
e7fa39f
to
77e0643
Compare
jctanner
approved these changes
Dec 5, 2022
awcrosby
reviewed
Dec 5, 2022
awcrosby
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing:
Properly use the new collection-version upload refactor in pulp_ansible. @newswangerd
Reviewers must know:
This is the temporary solution until we can move over the CollectionUploadViewSet to pulp_ansible. Other features like lockless import and the namespace migration require the collection upload refactor so this is important to unblock them.
Required PR: pulp/pulp_ansible#1176
Notes:
PR Author: Add a QE reviewer (exceptions);
Reviewers: look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit