Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use galaxy-importer import_legacy_role #1748

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

EamonTracey
Copy link
Contributor

Use the new LegacyRoleLoader class in updated galaxy-importer to import legacy roles

@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for galaxyng ready!

Name Link
🔨 Latest commit 44a8d63
🔍 Latest deploy log https://app.netlify.com/sites/galaxyng/deploys/64889bc901cc8e0008ee8dfe
😎 Deploy Preview https://deploy-preview-1748--galaxyng.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels May 30, 2023
@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@jctanner jctanner removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Jun 6, 2023
@EamonTracey EamonTracey force-pushed the legacy-role branch 4 times, most recently from 6f4e92d to a576842 Compare June 23, 2023 18:59
@EamonTracey EamonTracey force-pushed the legacy-role branch 2 times, most recently from 9205b80 to 893a283 Compare July 19, 2023 13:21
@EamonTracey EamonTracey force-pushed the legacy-role branch 5 times, most recently from 7a52204 to 4330996 Compare August 1, 2023 19:10
@EamonTracey EamonTracey changed the title use galaxy-importer LegacyRoleLoader use galaxy-importer import_legacy_role Aug 1, 2023
No-Issue

Signed-off-by: eamontracey <etracey@redhat.com>
@EamonTracey EamonTracey marked this pull request as ready for review August 1, 2023 19:20
No-Issue

Signed-off-by: eamontracey <etracey@redhat.com>
@jctanner
Copy link
Collaborator

jctanner commented Aug 1, 2023

/retest

@jctanner
Copy link
Collaborator

jctanner commented Aug 1, 2023

devshift is broken ...

18:32:23 /var/lib/jenkins/workspace/ansible-galaxy_ng-pr-check/.bonfire/bin/oc_wrapper
18:32:23 2023-08-01 22:32:23 [    INFO] [          MainThread] checking pypi for latest release...
18:32:23 2023-08-01 22:32:23 [    INFO] [          MainThread] up-to-date!
18:32:23 2023-08-01 22:32:23 [ WARNING] [          MainThread] split() requires a non-empty pattern match.
18:32:24 2023-08-01 22:32:24 [    INFO] [          MainThread] Checking for existing reservations for 'ansible-galaxy_ng-pr-check-2810'
18:32:24 2023-08-01 22:32:24 [    INFO] [          MainThread] checking for available namespaces to reserve...
18:32:24 2023-08-01 22:32:24 [    INFO] [          MainThread] pool size limit is defined as 0 in 'default' pool
18:32:24 2023-08-01 22:32:24 [    INFO] [          MainThread] processing namespace reservation
18:32:24 2023-08-01 22:32:24 [    INFO] [          MainThread] running (pid 20326): oc apply -f - 
18:32:25 2023-08-01 22:32:25 [    INFO] [           pid-20326]  |stdout| namespacereservation.cloud.redhat.com/bonfire-reservation-dd6e2342 created
18:32:25 2023-08-01 22:32:25 [    INFO] [          MainThread] waiting for reservation 'bonfire-reservation-dd6e2342' to get picked up by operator
18:32:26 2023-08-01 22:32:26 [    INFO] [          MainThread] namespace 'ephemeral-degpnh' is reserved by 'ansible-galaxy_ng-pr-check-2810' for '1h' from the default pool
18:32:26 2023-08-01 22:32:26 [    INFO] [          MainThread] namespace console url: https://console-openshift-console.apps.c-rh-c-eph.8p0c.p1.openshiftapps.com/k8s/cluster/projects/ephemeral-degpnh
18:32:27 2023-08-01 22:32:27 [ WARNING] [          MainThread] split() requires a non-empty pattern match.
18:32:28 2023-08-01 22:32:28 [    INFO] [          MainThread] processing app templates...
18:32:28 2023-08-01 22:32:28 [    INFO] [          MainThread] reading config from: /var/lib/jenkins/.config/bonfire/config.yaml
18:32:28 2023-08-01 22:32:28 [    INFO] [          MainThread] fetching apps config using source: appsre, target env: insights-ephemeral
18:32:29 2023-08-01 22:32:29 [    INFO] [          MainThread] local app configuration overrides found for: ['my_custom_app']
18:32:29 2023-08-01 22:32:29 [    INFO] [          MainThread] subbing app template refs/image tags using environment: insights-stage
18:32:30 2023-08-01 22:32:30 [   ERROR] [          MainThread] hit fatal error: component 'sed-frontend' is not unique, found in apps: ['config-manager', 'insights-ephemeral']
18:32:30 ERROR: deploy failed: component 'sed-frontend' is not unique, found in apps: ['config-manager', 'insights-ephemeral']
18:32:30 /var/lib/jenkins/workspace/ansible-galaxy_ng-pr-check/.bonfire/bin/oc_wrapper

@jctanner jctanner merged commit c2a7ab2 into ansible:master Aug 1, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants