dynamic API_HOSTNAME & CONTENT_ORIGIN via dynaconf+django-crum #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
multi-commit
backport-4.2
jctanner
removed
backport-4.2
rochacbruno
reviewed
May 7, 2024
rochacbruno
reviewed
May 7, 2024
rochacbruno
reviewed
May 7, 2024
rochacbruno
reviewed
May 7, 2024
rochacbruno
reviewed
May 7, 2024
rochacbruno
reviewed
May 7, 2024
rochacbruno
reviewed
May 7, 2024
rochacbruno
reviewed
May 7, 2024
Merged
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner
changed the title
jctanner
requested review from
rochacbruno,
cutwater,
himdel,
bmclaughlin,
newswangerd,
chr-stian,
simaishi,
jerabekjiri,
MilanPospisil,
drodowic and
a team
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
chr-stian
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end result of this is that the download_url for a collection version and the redirected urls from those url will resemble whatever protocol+host your client connected to the server with. This should enable downloadable collections from the hub AND through a gateway at the same time.