You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As we previously had some problems with sh library and today a new release also broke us, it is time to remove it as a dependency.
If someone makes a PR to remove sh and replace it with either an internal implementation or another library that is better maintained (test coverage and multiple maintainers), I will be very happy to fast-track it.
Plumbum seems nice but I did not test it yet. Also seems to be another project backed by a single developer, which worries me. I am more inclined to add some DIY code than ending up in the same place one year later. Still, no action will be taken unless we have a strong reason.
I have had good luck with plumbum in the past, and it has been pretty solidly stable. But for the amount of calling that Molecule does, we can do this ourselves with popen.
As we previously had some problems with
sh
library and today a new release also broke us, it is time to remove it as a dependency.If someone makes a PR to remove sh and replace it with either an internal implementation or another library that is better maintained (test coverage and multiple maintainers), I will be very happy to fast-track it.
Related: #2676
The text was updated successfully, but these errors were encountered: