Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sh package as a molecule dependency #2678

Closed
ssbarnea opened this issue Apr 28, 2020 · 5 comments · Fixed by #2917
Closed

Remove sh package as a molecule dependency #2678

ssbarnea opened this issue Apr 28, 2020 · 5 comments · Fixed by #2917
Assignees
Milestone

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Apr 28, 2020

As we previously had some problems with sh library and today a new release also broke us, it is time to remove it as a dependency.

If someone makes a PR to remove sh and replace it with either an internal implementation or another library that is better maintained (test coverage and multiple maintainers), I will be very happy to fast-track it.

Related: #2676

@ssbarnea ssbarnea added this to the 3.0.5 milestone Apr 28, 2020
@ssbarnea ssbarnea pinned this issue Apr 28, 2020
@decentral1se
Copy link
Contributor

Regression was handled in a timely manner, however.

amoffat/sh#520 (comment)

@yajo
Copy link
Contributor

yajo commented Jul 27, 2020

https://plumbum.readthedocs.io/ rocks 🎸

@ssbarnea
Copy link
Member Author

Plumbum seems nice but I did not test it yet. Also seems to be another project backed by a single developer, which worries me. I am more inclined to add some DIY code than ending up in the same place one year later. Still, no action will be taken unless we have a strong reason.

@greg-hellings
Copy link
Contributor

I have had good luck with plumbum in the past, and it has been pretty solidly stable. But for the amount of calling that Molecule does, we can do this ourselves with popen.

@ssbarnea ssbarnea self-assigned this Oct 26, 2020
@ssbarnea
Copy link
Member Author

I started working on this during the weekend, implemention would count as major change which will impact plugins, so it will only go in in 3.2.0.

@ssbarnea ssbarnea modified the milestones: 3.0.5, 3.2.0 Oct 27, 2020
@ssbarnea ssbarnea unpinned this issue Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants