Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on sh library #2917

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Remove dependency on sh library #2917

merged 1 commit into from
Oct 27, 2020

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Oct 27, 2020

  • Main change is replace use of sh library with subprocess-tee while adopting a loose-coupling approach, so we do not rely on implementation details of the subprocess library.
  • This will be part of 3.2.0 major release as it will likely break at least some plugins that are using molecule.util.run_command or the bake().
  • It will initially be tagged as 3.2.0a0 in order to give time for plugin projects to adapt their test suites.
  • This enables us to capture and process the output of the executed commands while still displaying it in real time, still no extra processing is done in this change.

Fixed: #2678
Related: amoffat/sh#450 amoffat/sh#512

@ssbarnea ssbarnea added the major label Oct 27, 2020
@ssbarnea ssbarnea added this to the 3.2.0 milestone Oct 27, 2020
@ssbarnea ssbarnea force-pushed the rm/sh branch 2 times, most recently from f6acc7d to 8882673 Compare October 27, 2020 14:21
@ssbarnea ssbarnea changed the title WIP: Remove use of sh library Remove dependency on sh library Oct 27, 2020
@ssbarnea ssbarnea marked this pull request as ready for review October 27, 2020 14:23
@ghost
Copy link

ghost commented Oct 27, 2020

I like the simplicity of subprocess-tee.

@ssbarnea ssbarnea merged commit 1cefe5c into master Oct 27, 2020
@ssbarnea ssbarnea deleted the rm/sh branch October 27, 2020 16:37
ssbarnea added a commit to ansible-community/molecule-docker that referenced this pull request Oct 28, 2020
ssbarnea added a commit to ansible-community/molecule-docker that referenced this pull request Oct 28, 2020
ssbarnea added a commit to ansible-community/molecule-podman that referenced this pull request Oct 28, 2020
ssbarnea added a commit to ansible-community/molecule-podman that referenced this pull request Oct 28, 2020
ssbarnea added a commit to ansible-community/molecule-podman that referenced this pull request Oct 28, 2020
ssbarnea added a commit to ansible-community/molecule-vagrant that referenced this pull request Oct 28, 2020
ssbarnea added a commit to ansible-community/molecule-vagrant that referenced this pull request Oct 28, 2020
ssbarnea added a commit to ansible-community/molecule-vagrant that referenced this pull request Oct 28, 2020
@decentral1se
Copy link
Contributor

👏 👏 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sh package as a molecule dependency
2 participants