Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only test default driver with delegated #2146

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Only test default driver with delegated #2146

merged 1 commit into from
Jul 5, 2019

Conversation

decentral1se
Copy link
Contributor

Hear me out first before clicking no.

  • "Delegated" is known as the "you're on your own" driver choice and I am A-OK with only testing the ability for it to work with the default driver as a sanity check that it still does what it says it does
  • We can significantly reduce the workload of the functional tests in this way so that we can work towards removing the sharding that will simplify the entire functional testing setup.
  • We don't have resources to test this. If Zuul CI every does land (no guarantee), we might have more (but my first reason is enough IMHO). It's uncessary workload which is not sustainable for our resources, both in terms of computers and human capacity.

@decentral1se decentral1se added the test Improvement to quality assurance: CI/CD, testing, building label Jul 3, 2019
@decentral1se
Copy link
Contributor Author

/cc @ssbarnea RE: "test consolidation"

@decentral1se decentral1se mentioned this pull request Jul 3, 2019
Closed
@ssbarnea ssbarnea self-requested a review July 3, 2019 15:20
@decentral1se decentral1se mentioned this pull request Jul 3, 2019
Closed
@decentral1se decentral1se force-pushed the cifix/reduce-functional-testing branch from d3ad26e to b7c79af Compare July 5, 2019 10:35
ssbarnea
ssbarnea approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in love with matrix approach but that change makes sense for the moment.

@decentral1se
Copy link
Contributor Author

that change makes sense for the moment.

💯

@decentral1se decentral1se merged commit a0b8127 into ansible:master Jul 5, 2019
@decentral1se decentral1se deleted the cifix/reduce-functional-testing branch July 5, 2019 11:59
@decentral1se decentral1se mentioned this pull request Jul 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
test Improvement to quality assurance: CI/CD, testing, building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@decentral1se @ssbarnea