Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upper bound for sh dependency #2677

Closed
wants to merge 1 commit into from
Closed

Add upper bound for sh dependency #2677

wants to merge 1 commit into from

Conversation

decentral1se
Copy link
Contributor

@decentral1se decentral1se commented Apr 28, 2020 •
edited by ssbarnea
Loading

Fixes: #2676.

@ssbarnea ssbarnea added the gate label Apr 28, 2020
@ssbarnea ssbarnea changed the title Add upper bound on sh for now Add upper bound for sh dependency Apr 28, 2020
@ssbarnea ssbarnea added the packaging installation, packaging, built containers label Apr 28, 2020
@ssbarnea ssbarnea added this to the 3.0.4 milestone Apr 28, 2020
@ansible-zuul ansible-zuul bot removed the gate label Apr 28, 2020
@decentral1se
Copy link
Contributor Author

decentral1se commented Apr 28, 2020 •
edited
Loading

I've updated the bound to account for the new sh release.

The urgency of a required release is not really an issue now btw.

Wait, I'm still seeing failures.... :( see #2676 for more...

@robinmulder
Copy link
Contributor

robinmulder commented Apr 28, 2020 •
edited
Loading

Until there is a proper fix, this should probably be:

sh >= 1.12.14, < 1.13

Created #2679.

@decentral1se
Copy link
Contributor Author

Let's go with #2679.

@decentral1se decentral1se deleted the pin-sh-package branch April 28, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
packaging installation, packaging, built containers
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.

Broken dependency from pip's sh module
3 participants
@decentral1se @robinmulder @ssbarnea