Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly construct collections path #3085

Merged

Conversation

tadeboro
Copy link
Contributor

Changes in this commit make sure we do not fail if the ansible collection we are testing is nested under some other collection.

Fixes #3072

PR Type

  • Bugfix Pull Request

@tadeboro tadeboro force-pushed the fix-nested-ansible-collections branch from e8c6e80 to 27e76a2 Compare March 28, 2021 20:14
@tadeboro
Copy link
Contributor Author

Not sure what to do with the failing eco test since I have no control over the hetzner driver. It has nothing to do with the changes introduced in the PR.

@tadeboro tadeboro closed this Mar 28, 2021
@tadeboro tadeboro deleted the fix-nested-ansible-collections branch March 28, 2021 20:22
@tadeboro tadeboro restored the fix-nested-ansible-collections branch March 28, 2021 20:26
@tadeboro tadeboro reopened this Mar 28, 2021
@aminvakil
Copy link
Contributor

Needs a close/repoen: ansible-community/molecule-hetznercloud#27 (comment)

@tadeboro tadeboro closed this Apr 30, 2021
@tadeboro tadeboro reopened this Apr 30, 2021
@tadeboro tadeboro force-pushed the fix-nested-ansible-collections branch from 27e76a2 to 6d7a71f Compare April 30, 2021 18:18
Changes in this commit make sure we do not fail if the Ansible
collection we are testing is nested under some other collection.
@tadeboro tadeboro force-pushed the fix-nested-ansible-collections branch from 6d7a71f to cce31d8 Compare April 30, 2021 18:48
@tadeboro tadeboro enabled auto-merge (squash) April 30, 2021 18:51
@tadeboro tadeboro merged commit 56abe29 into ansible:master Apr 30, 2021
@tadeboro tadeboro deleted the fix-nested-ansible-collections branch April 30, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-nested ansible_collections folders cause errors
3 participants