Fix ANSIBLE_LIBRARY variable handling #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tadeboro please rebase and thanks for addresing it. |
ssbarnea
approved these changes
May 14, 2021
When we introduced the ability to pass down the user-specified ANSIBLE_LIBRARY variable value to the molecule, we wrongly assumed that the variable will always contain a single componet, which is not always true. This commit makes sure that we properly handle scenarios where users specify multiple directories in the ANSIBLE_LIBRARY environment variable.
tadeboro
force-pushed
the
fix-ansible-library-construction
branch
from
fd7c4be
to
c6eb282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we introduced the ability to pass down the user-specified ANSIBLE_LIBRARY variable value to the molecule, we wrongly assumed that the variable will always contain a single component, which is not always true.
This commit makes sure that we properly handle scenarios where users specify multiple directories in the ANSIBLE_LIBRARY environment variable.
Fixes #3083
PR Type