Make sure run_command properly combines envs #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because dictionary's update method updates data in place and does not return anything back, the run_command method executed baked commands with env overrides with an empty env. This commit makes sure environments are properly combined.
tadeboro
force-pushed
the
fix-util-run-command-env-handling
branch
from
c2b82b7
to
0afc08f
Compare
ssbarnea
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the dictionary's update method updates data in place and does not return anything, the run_command method executed baked commands with env overrides with an empty env. This commit makes sure environments are properly combined.
PR Type