Make sure we detect dependency installation failure

[tadeboro]

Right now, we just ignore the failure because we do not check the return code of the children's process. This commit just makes sure we are notified when the dependency command fails.

Fixes #3070

PR Type

• Bugfix Pull Request

[fourstepper]

In GitLab CI, it is quite easy to pull dependencies from gitlab over HTTPs without a secret by setting the git config like this: git config --global url."https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.com/".insteadOf https://gitlab.com/

As I have this set, this PR is a regression for me, as molecule just fails on dependency resolution, when before I could just enter away at it and it would pick up roles downloaded through a different requirements file (over SSH)

Is it possible to change the behaviour to either not make this default or make it optional to check successful dependency download? Perhaps with an environment variable?

[ssbarnea]

I not think failure to install deps should be ignored but if you propose a PR that sorts your use case without affecting other users I will likely accept it.

[tadeboro]

Silently ignoring the fact that dependencies were not installed is not something one should do by default. I would suggest that you parameterize your molecule configuration file using an environment variable that controls whether dependency installation should be attempted or not. Something like this should work:

dependency:
  name: galaxy
  enabled: ${INSTALL_DEPS:-true}

Then we can set the INSTALL_DEPS variable to false if we would like to skip the dependency installation.

[fourstepper]

You are right. By default we shouldn't ignore dependency installation failures. This is a good enough solution. Thank you