Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

molecule test add support of ansible args #3166

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jun 25, 2021

When running molecule test ansible args are now supported:

molecule test -s test_scenario --driver-name test_driver -- -v --tags test --diff

PR Type

  • Feature Pull Request

Copy link
Contributor

@tadeboro tadeboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are a bit misleading, but once that is fixed, I think this is ready to go.

src/molecule/command/test.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tadeboro tadeboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like black is not liking some formatting of the change, so this needs to be fixed.

The docs build fails because pip changed its documentation a bit and the intersphinx does not find the relevant document anymore. I prepared a fix for that in #3168 which should auto-resolve issues in this PR once it is merged.

@abikouo abikouo requested a review from tadeboro June 29, 2021 07:54
Copy link
Contributor

@tadeboro tadeboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said before, black is complaining. Before we can merge this, that issue must be resolved.

@tadeboro tadeboro merged commit d6985be into ansible:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants