Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema: Allow additionalProperties in ProvisionerConfigOptionsSshConnectionModel #3721

Merged
merged 2 commits into from
Nov 1, 2022
Merged

JSON Schema: Allow additionalProperties in ProvisionerConfigOptionsSshConnectionModel #3721

merged 2 commits into from
Nov 1, 2022

Conversation

fredflev
Copy link
Contributor

@fredflev fredflev commented Nov 1, 2022

Based on the discussion in the following issue

This change allow a molecule user to set any additional ssh_connection options needed for the provisioner object in molecule.yml.

@fredflev fredflev requested review from a team as code owners November 1, 2022 14:43
@fredflev fredflev requested review from apatard, sky-joker, cidrblock, priyamsahoo and shatakshiiii and removed request for a team November 1, 2022 14:43
@fredflev fredflev changed the title Json schema: Allow additionalProperties in ProvisionerConfigOptionsSshConnectionModel JSON Schema: Allow additionalProperties in ProvisionerConfigOptionsSshConnectionModel Nov 1, 2022
@zhan9san zhan9san added the bug label Nov 1, 2022
@zhan9san zhan9san merged commit 54bade8 into ansible:main Nov 1, 2022
@zhan9san
Copy link
Contributor

zhan9san commented Nov 1, 2022

@fredflev
Thanks for your work

@fredflev fredflev deleted the fl-allow-add-prop-ssh-con-model branch November 1, 2022 15:12
davedittrich pushed a commit to davedittrich/molecule that referenced this pull request Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants