Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "default" as a valid docker "network_mode" in molecule.json schema #3724

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Add "default" as a valid docker "network_mode" in molecule.json schema #3724

merged 1 commit into from
Nov 3, 2022

Conversation

fredflev
Copy link
Contributor

@fredflev fredflev commented Nov 3, 2022 •
edited
Loading

As per discussion in: #3723

Without the change in this PR, the molecule schema validation step fails and throw this "not so obvious" error:

molecule --debug syntax                                        
DEBUG    Validating schema /Users/My_User/ansible-role/molecule/default/molecule.yml.
CRITICAL Failed to validate /Users/My_User/ansible-role/molecule/default/molecule.yml

["'default' is not valid under any of the given schemas"]

And reference in: https://docs.ansible.com/ansible/latest/collections/community/docker/docker_container_module.html#parameter-network_mode

@fredflev fredflev requested review from a team as code owners November 3, 2022 06:19
@fredflev fredflev requested review from Shaps, jseguillon, trishnaguha, cidrblock and priyamsahoo and removed request for a team November 3, 2022 06:19
@fredflev fredflev changed the title Add "default" as a valid docker network_mode in JSON Schema Add default as a valid docker network_mode in JSON Schema Nov 3, 2022
@zhan9san zhan9san added the bug label Nov 3, 2022
@fredflev fredflev changed the title Add default as a valid docker network_mode in JSON Schema Add "default" as a valid docker "network_mode" in molecule.json schema Nov 3, 2022
@zhan9san zhan9san merged commit 52faa66 into ansible:main Nov 3, 2022
@fredflev fredflev mentioned this pull request Nov 3, 2022
Merged
@fredflev fredflev deleted the json-schema-allow-default-docker-container-network branch November 3, 2022 07:43
@fredflev fredflev restored the json-schema-allow-default-docker-container-network branch November 4, 2022 06:01
davedittrich pushed a commit to davedittrich/molecule that referenced this pull request Dec 4, 2022
@davedittrich
add option for default network_mode (ansible#3724)
0321ee5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@Shaps Shaps Awaiting requested review from Shaps Shaps was automatically assigned from ansible-community/molecule

@jseguillon jseguillon Awaiting requested review from jseguillon jseguillon was automatically assigned from ansible-community/molecule

@trishnaguha trishnaguha Awaiting requested review from trishnaguha trishnaguha was automatically assigned from ansible-community/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock was automatically assigned from ansible-community/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredflev @felixfontein @zhan9san