Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running tox:dockerfile with docker secretservice enabled #3764

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Fix running tox:dockerfile with docker secretservice enabled #3764

merged 1 commit into from
Dec 2, 2022

Conversation

zeitounator
Copy link
Contributor

This PR fixes issue #3758 which was later migrated to discussion #3759.

As a short summary of the posts above.

The problem happens when you have configured secretservice as your credstore in your docker configfile (e.g. ~/.docker.config.json)

running tox -e dockerfile launches the playbook src/molecule/data/validate-dockerfile.yml which then fails at image build taks with error

ansible_collections.community.docker.plugins.module_utils._api.credentials.errors.StoreError: Credentials store docker-credential-secretservice exited with "Cannot autolaunch D-Bus without X11 $DISPLAY"

Passing the DISPLAY environment variable to tox fixes the issue.

@zeitounator zeitounator requested review from a team as code owners December 2, 2022 00:32
@zeitounator zeitounator requested review from ssbarnea, odyssey4me, priyamsahoo and shatakshiiii and removed request for a team December 2, 2022 00:32
@github-actions github-actions bot added the bug label Dec 2, 2022
@zhan9san
Copy link
Contributor

zhan9san commented Dec 2, 2022

Thanks for your contribution

@zhan9san zhan9san merged commit 3bfc755 into ansible:main Dec 2, 2022
davedittrich pushed a commit to davedittrich/molecule that referenced this pull request Dec 4, 2022
@zeitounator @davedittrich
Fix running tox:dockerfile with docker secretservice enabled (ansible…
c81467b 
…#3764)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea was automatically assigned from ansible-community/molecule

@odyssey4me odyssey4me Awaiting requested review from odyssey4me odyssey4me was automatically assigned from ansible-community/molecule

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii was automatically assigned from ansible-community/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeitounator @zhan9san