Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include env variables defined in a dependency in the step itself. #4047

Closed
wants to merge 5 commits into from

Commits on Nov 14, 2023

  1. Include env variables defined in a dependency in the step itself.

    Prior to this commit, a `dependency` defined by the `molecule.yaml` file
    would not honor the values in its `env` map. Consider the following:
    
    ```yaml
    dependency:
      name: shell
      command: env
      env:
        FOO: bar
    ```
    
    Invoking `molecule test` would show that `FOO` is not set during the run
    of this dependency. The cause was the fact that these values were never
    actually passed to the `util.run_command()` invocation. This also means
    `MOLECULE_EPHEMERAL_DIRECTORY` and similar `MOLECULE_*` environment
    variables that are defined by the dependency's `default_env` property
    were also never available to the dependency's environment.
    fabacab authored and zhan9san committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    8caa1a3 View commit details
    Browse the repository at this point in the history
  2. [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci
    pre-commit-ci[bot] authored and zhan9san committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    88071dd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba94914 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Configuration menu
    Copy the full SHA
    259e339 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    b155597 View commit details
    Browse the repository at this point in the history