added Dockerfile #520
Closed
added Dockerfile #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Powell <rob@robpowell.engineering>
retr0h
reviewed
Oct 4, 2016
| @@ -0,0 +1,13 @@ | |||
| FROM python:3.3 | |||
There was a problem hiding this comment.
FYI - Molecule is currently only python 2.7 compatible.
|
Hi @robtec, thanks for thinking of us and sending us a PR. I'm probably going to hold off on this, and get a feel for what other developers are doing. We haven't had any issues around this, and might cause confusion if we cannot support a molecule-docker workflow. Also, to run a molecule development environment, it requires vagrant/virtualbox and docker as well. Again, appreciate the PR, I'd just like to hold off for now. |
|
Hey, yes this wouldn't play well with virtual box, would require a bind mount to the host docker sock for docker to work also. Appreciate your feedback, thank you |
apatard
added a commit
to apatard/molecule
that referenced
this pull request
Apr 29, 2020
Since sh.py 1.13, a new check on the environment variables has been added with commit amoffat/sh@5b27477. This leads to failures in the testsuite since the code is passing os.environ, which is not a dict(). It's also breaking MOLECULE_ENV_FILE handling with errors like (from the testsuite): E TypeError: Invalid special arguments: E E 'env': value None of env key 'MOLECULE_ENV_FILE' must be a str so: - use dict() to convert os.environ to a dict in _rebake_command(), - use str() when defining MOLECULE_ENV_FILE to make sure self.env_file is a string. To avoid any other surprise with 1.14 or newer, I've changed the sh.py requirement to < 1.14. The requirement is not 1.13 but 1.13.1 to get the fix for sh.py bug ansible#520 (amoffat/sh#520). Signed-off-by: Arnaud Patard <apatard@hupstream.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As I don't have a python development environment, I made a Dockerfile to build the latest.
Figured might be worth contributing it back to you guys
Initial thoughts?
Signed-off-by: Rob Powell rob@robpowell.engineering