Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

become_loader is a member of ansible.plugins.loader #40

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

pguermo
Copy link
Contributor

@pguermo pguermo commented Aug 30, 2019

No description provided.

@pguermo
Copy link
Contributor Author

pguermo commented Aug 30, 2019

@jlaska: has something changed in the configuration of the CI? I wonder this small change has broken the CI?

@pguermo
Copy link
Contributor Author

pguermo commented Sep 5, 2019

@abadger Is something wrong now with the configuration of the project on Travis CI? I cannot understand how my commit may have broken that much the tests...

Copy link
Member

@kdelee kdelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, sorry for delay! Feel free to ping me directly in the future

@kdelee
Copy link
Member

kdelee commented Sep 13, 2019

Looks like the unit tests are busted, will look into it

@kdelee
Copy link
Member

kdelee commented Sep 13, 2019

#41 fixed CI, think it has just been some drift in stdout + at least locally, the version of pytest I have needs these newer import paths

@kdelee
Copy link
Member

kdelee commented Sep 18, 2019

@pguermo if you rebase, I think CI should pass and then once that passes I will merge

@coveralls
Copy link

coveralls commented Sep 19, 2019

Pull Request Test Coverage Report for Build 202

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.04%) to 64.88%

Totals Coverage Status
Change from base Build 201: -1.04%
Covered Lines: 1622
Relevant Lines: 2500

💛 - Coveralls

@pguermo
Copy link
Contributor Author

pguermo commented Sep 19, 2019

@kdelee I've made the rebase, but CI is still complaining... ProtocolError: 'Connection broken' while collecting ansible

@pguermo
Copy link
Contributor Author

pguermo commented Sep 24, 2019

Hello @kdelee, Is there any way to rerun the CI without any commit? I expect the failure was not related to the code itself but much more related to the environment. Thanks

@kdelee
Copy link
Member

kdelee commented Sep 26, 2019

@pguermo re-kicked failed job. Looks like local network flake on the test runner box to me

@kdelee
Copy link
Member

kdelee commented Sep 26, 2019

Fixed!

Going to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants