Add unused-import & wrong-import-order check
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruchip16
requested review from
ganeshrn,
trishnaguha,
shatakshiiii,
ssbarnea and
cidrblock
and removed request for
a team
ssbarnea
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unused-importcheck ensures that there is no imported module unused in the codebase.The
wrong-import-ordercheck ensures that the imported module follows recommended conventions. The recommended convention is to import built-in modules first, followed by third-party modules, and then local modules.By following this convention, our code becomes more readable and easier to maintain, as it is easier to identify where each module is coming from.
Related to #85