Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the framework and mocks for testing udp_proxy.go #1209

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

AaronH88
Copy link
Contributor

This is the framework for testing,
I will make the tests in a following PR

@AaronH88 AaronH88 requested a review from matoval November 14, 2024 14:33
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 40.39%. Comparing base (597a6bc) to head (9cd5ea8).
Report is 1 commits behind head on devel.

Files with missing lines Patch % Lines
pkg/services/udp_proxy.go 25.00% 27 Missing ⚠️
@@            Coverage Diff             @@
##            devel    #1209      +/-   ##
==========================================
+ Coverage   39.17%   40.39%   +1.21%     
==========================================
  Files          45       48       +3     
  Lines        9260     9846     +586     
==========================================
+ Hits         3628     3977     +349     
- Misses       5363     5589     +226     
- Partials      269      280      +11     
Files with missing lines Coverage Δ
pkg/services/udp_proxy.go 41.05% <25.00%> (+41.05%) ⬆️

... and 11 files with indirect coverage changes

Components Coverage Δ
Go 39.83% <25.00%> (+0.65%) ⬆️
Receptorctl 49.31% <ø> (∅)

Copy link
Collaborator

@matoval matoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 force-pushed the udp_proxy_tests branch 2 times, most recently from fdc7e9e to 4babfdc Compare November 28, 2024 13:57
Copy link

sonarcloud bot commented Nov 28, 2024

@AaronH88 AaronH88 merged commit aa2756f into ansible:devel Nov 28, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants