-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build and publish binaries on release by using make and action-gh-release #724
Conversation
@kurokobo ur the coolest ❤️ |
Thanks for moving forward this PR. |
team, some news on it? |
This looks great! |
8cb434f
to
51fc748
Compare
@AaronH88 As for the documentation, I just wrote an overview without mentioning specific tools, what do you think? |
great work @kurokobo , running the github actions now 😄 |
@shanemcd this PR linting is throwing a false positive. |
@kurokobo I have just checked with the internal team and the action permissions are set to "Read and Write", |
51fc748
to
1e201d0
Compare
@AaronH88 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Closes #719
@TheRealHaoLiu
I saw that you were already assigned to the issue, so feel free to ignore this PR, but I've created this as a working demo 😃
Design
In this PR, I use
make
andaction-gh-release
to build and publish binaries.make
andaction-gh-release
GoReleaser
v1.3.0.dev1
is not allowed)The pros for GoReleaser is that it also supports building RPMs in addition to just binaries, but compiling SELinux policies and generating Bash Completion are required before GoReleaer, so it ends up being a bit more complicated.
Also, since non-semver tags are not allowed, the workflow will fail if we pass the tags like
v1.3.0.dev1
when releasing manually.So, first, I've created a PR to publish binaries using
make
in a straightforward and simple manner.For demo purpose, GoReleaser version is here: #725
Test
Demo release is available on my forked repository: https://github.com/kurokobo/receptor/releases/tag/v1.3.1-demo1a
publish
inpromote.yml
to be completed.