Add unit tests for framer.go #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resoluteCoder
force-pushed
the
test-framer-pkg2
branch
from
2012978 to
7b46927
Compare
AaronH88
reviewed
Aug 16, 2023
AaronH88
reviewed
Aug 16, 2023
pkg/framer/framer_test.go
Outdated
|
|
||
| for _, testCase := range messageReadyTestCases { | ||
| f := framer.New() | ||
| f.RecvData(testCase.inputBuffer) |
There was a problem hiding this comment.
Lets wrap this code block in a t.Run()
There was a problem hiding this comment.
Same on line 37, lets wrap this in a t.Run() block
|
In the PR message This way your commit history will be the one from yesterday that called out the |
resoluteCoder
force-pushed
the
test-framer-pkg2
branch
from
7b46927 to
ff4e3d3
Compare
resoluteCoder
changed the title
resoluteCoder
force-pushed
the
test-framer-pkg2
branch
from
ff4e3d3 to
33079bc
Compare
resoluteCoder
force-pushed
the
test-framer-pkg2
branch
from
33079bc to
4c814e5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
AaronH88
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.