Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for controlsvc control types #865

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Add tests for controlsvc control types #865

merged 1 commit into from
Oct 2, 2023

Conversation

resoluteCoder
Copy link
Contributor

No description provided.

@resoluteCoder resoluteCoder force-pushed the controlsvc-control-types branch 2 times, most recently from 989ce23 to 3ac33d3 Compare September 28, 2023 15:03
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #865 (2a32273) into devel (5f5094f) will increase coverage by 1.92%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##            devel     #865      +/-   ##
==========================================
+ Coverage   34.12%   36.04%   +1.92%     
==========================================
  Files          44       44              
  Lines        8555     8555              
==========================================
+ Hits         2919     3084     +165     
+ Misses       5393     5225     -168     
- Partials      243      246       +3
Files Coverage Δ
pkg/controlsvc/connect.go 100.00% <100.00%> (+100.00%) ⬆️
pkg/controlsvc/controlsvc.go 74.63% <100.00%> (ø)
pkg/controlsvc/ping.go 100.00% <100.00%> (+86.11%) ⬆️
pkg/controlsvc/status.go 100.00% <100.00%> (+100.00%) ⬆️
pkg/controlsvc/traceroute.go 100.00% <100.00%> (+100.00%) ⬆️
pkg/controlsvc/reload.go 69.60% <60.00%> (ø)

... and 3 files with indirect coverage changes

@resoluteCoder resoluteCoder force-pushed the controlsvc-control-types branch 5 times, most recently from ad003de to 4ce40ea Compare September 28, 2023 16:05
@resoluteCoder resoluteCoder marked this pull request as ready for review September 28, 2023 16:07
@resoluteCoder resoluteCoder force-pushed the controlsvc-control-types branch from 4ce40ea to 1594658 Compare September 28, 2023 16:09
@resoluteCoder resoluteCoder force-pushed the controlsvc-control-types branch 2 times, most recently from 2065d6f to c1ab859 Compare October 2, 2023 13:00
@resoluteCoder resoluteCoder force-pushed the controlsvc-control-types branch from c1ab859 to 2a32273 Compare October 2, 2023 13:05
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

AaronH88
AaronH88 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 45d7df5 into ansible:devel Oct 2, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronH88 AaronH88 AaronH88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@resoluteCoder @AaronH88