New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for workunitbase and wrap fsnotify library calls #866

Merged

AaronH88 merged 3 commits into ansible:devel from AaronH88:workunit_tests2

Oct 10, 2023

Contributor

AaronH88 commented Oct 3, 2023

No description provided.

codecov bot commented Oct 3, 2023 •

edited

Loading

Codecov Report

Merging #866 (0fd7df6) into devel (6740b44) will increase coverage by 1.59%.
The diff coverage is 46.80%.

@@            Coverage Diff             @@
##            devel     #866      +/-   ##
==========================================
+ Coverage   36.01%   37.60%   +1.59%     
==========================================
  Files          44       44              
  Lines        8555     8568      +13     
==========================================
+ Hits         3081     3222     +141     
+ Misses       5227     5100     -127     
+ Partials      247      246       -1

Files	Coverage Δ
pkg/workceptor/python.go	`7.89% <0.00%> (ø)`
pkg/workceptor/remote_work.go	`0.00% <0.00%> (ø)`
pkg/workceptor/kubernetes.go	`2.99% <0.00%> (ø)`
pkg/workceptor/stdio_utils.go	`89.04% <0.00%> (-2.51%)`	⬇️
pkg/workceptor/command.go	`11.25% <0.00%> (ø)`
pkg/workceptor/workunitbase.go	`71.15% <57.89%> (+43.57%)`	⬆️

... and 2 files with indirect coverage changes

AaronH88 force-pushed the workunit_tests2 branch 2 times, most recently from c04d06e to 3564f12 Compare

October 4, 2023 10:10

AaronH88 added 2 commits

October 4, 2023 16:58


          Add unit tests for workunitbase and wrap fsnotify library calls

04926e5


          Fix code smells and linting errors

81fb5e0

AaronH88 force-pushed the workunit_tests2 branch from 3564f12 to 81fb5e0 Compare

October 4, 2023 16:01

AaronH88 commented

View reviewed changes

pkg/workceptor/workunitbase.go Show resolved Hide resolved

AaronH88 commented

View reviewed changes

pkg/workceptor/workunitbase.go Show resolved Hide resolved


          Add comment for new WatcherWrapper interface

0fd7df6

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

matoval approved these changes

View reviewed changes

AaronH88 merged commit 635ed43 into ansible:devel

17 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet