-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't error if log reconnection fails due to context canceled #875
Conversation
Don't retry either as the context won't become uncanceled
3c01948
to
5ae50ec
Compare
Logs from stern for the awx-task container when this happens (note the EOF on the container shortly before the context is canceled, making me think that something sees the pod fail and cancels the context):
|
This is not necessarily the best fix (maybe not canceling the context before receptor has marked the pod successful will help) but we've already seen it avoid the inventory update being marked as failed even after it's successfully completed (according to the update pod logs) |
Codecov Report
@@ Coverage Diff @@
## devel #875 +/- ##
==========================================
+ Coverage 37.60% 37.63% +0.03%
==========================================
Files 44 44
Lines 8568 8576 +8
==========================================
+ Hits 3222 3228 +6
- Misses 5102 5105 +3
+ Partials 244 243 -1
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Don't retry either as the context won't become uncanceled