Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert simple-network-diagram to drawio.png #886

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

TheRealHaoLiu
Copy link
Member

drawio.png can be edited in vscode with drawio plugin

https://marketplace.visualstudio.com/items?itemName=hediet.vscode-drawio

@TheRealHaoLiu TheRealHaoLiu requested a review from thenets October 23, 2023 19:03
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.9% 4.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #886 (ea7897b) into devel (72ade6d) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel     #886      +/-   ##
==========================================
+ Coverage   32.36%   32.48%   +0.12%     
==========================================
  Files          40       40              
  Lines        7360     7360              
==========================================
+ Hits         2382     2391       +9     
+ Misses       4844     4837       -7     
+ Partials      134      132       -2     

see 3 files with indirect coverage changes

Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 8a8cee2 into ansible:devel Oct 24, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants