Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubernetes version checking #956

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 62.26415% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 39.43%. Comparing base (478868e) to head (bb49006).

@@            Coverage Diff             @@
##            devel     #956      +/-   ##
==========================================
+ Coverage   39.20%   39.43%   +0.23%     
==========================================
  Files          42       42              
  Lines        6576     6606      +30     
==========================================
+ Hits         2578     2605      +27     
- Misses       3799     3802       +3     
  Partials      199      199              
Files Coverage Δ
pkg/workceptor/remote_work.go 11.91% <0.00%> (-0.03%) ⬇️
pkg/workceptor/kubernetes.go 19.57% <64.70%> (+1.80%) ⬆️

... and 4 files with indirect coverage changes

@thom-at-redhat thom-at-redhat marked this pull request as draft February 27, 2024 11:34
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
46.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@thom-at-redhat thom-at-redhat marked this pull request as ready for review February 27, 2024 14:10
Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 608ff52 into ansible:devel Feb 27, 2024
17 of 18 checks passed
@thom-at-redhat thom-at-redhat deleted the readd_kubernetes branch February 27, 2024 16:29
@AaronH88 AaronH88 changed the title Readd kubernetes version testing Add kubernetes version checking Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants