Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use prettier with markdown #386

Merged
merged 1 commit into from
Jan 17, 2022
Merged

chore: use prettier with markdown #386

merged 1 commit into from
Jan 17, 2022

Conversation

ssbarnea
Copy link
Member

That is enabling use of prettier with markdownfiles, so we do get surprise-reformatting when we edit .md files in our repo.

This should prevent recent problems that were seen with at least two incoming pull-requests, where prettier reformatted unrelated changes.

@ssbarnea
chore: use prettier with markdown
e1dc268 
That is enabling use of prettier with markdownfiles, so we do get
surprise-reformatting when we edit .md files in our repo.
@github-actions github-actions bot added the bug Something isn't working label Jan 17, 2022
@ssbarnea ssbarnea marked this pull request as ready for review January 17, 2022 17:44
@ssbarnea ssbarnea requested review from tomaciazek and a team as code owners January 17, 2022 17:44
priyamsahoo
priyamsahoo approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@priyamsahoo priyamsahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have always been in favor of having a prettier config file per project :)

cidrblock
cidrblock approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cool. TY. Consistency and automatic clean-up :)

@ssbarnea ssbarnea merged commit 7751bb0 into ansible:main Jan 17, 2022
@ssbarnea ssbarnea deleted the fix/prettier branch January 17, 2022 17:52
This was referenced Jan 18, 2022
Merged
Closed
ssbarnea added a commit that referenced this pull request Mar 15, 2024
@ssbarnea
chore: prepare md for prettier (#178)
49136ef 
Ensures that our markdown files do not contain syntax that would
be modified by prettier.

That is preparatory change containing some manual fixes that were
needed as part of #386 but we took them separately in order to
ease the review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyamsahoo priyamsahoo priyamsahoo approved these changes

@cidrblock cidrblock cidrblock approved these changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

@tomaciazek tomaciazek Awaiting requested review from tomaciazek

@relrod relrod Awaiting requested review from relrod relrod is a code owner automatically assigned from ansible/devtools

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug Something isn't working skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssbarnea @cidrblock @priyamsahoo