async viable tasks to speed up provision (security) #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Async various EC2 operations because they can run in parallel - Async package installs - Async select downloads This appears to achieve roughly a 1 minute per student environment speed increase which can be rather impactful for larger workshops (AnsibleFest notably). Before this patchset with 10 students --- real 39m48.828s user 5m52.074s sys 1m19.715s After this patchset with 10 students --- real 31m13.664s user 4m29.428s sys 1m25.586s Before this patchset with 20 students --- real 65m3.124s user 9m9.207s sys 2m25.135s After this patchset with 20 students --- real 45m13.722s user 8m31.238s sys 2m29.468s For posterity, I did run Roland's verifier playbook against the provisioned environment that results from these changes to ensure sanity checking and the verifier playbook was successful. Signed-off-by: Adam Miller <admiller@redhat.com> Signed-off-by: Adam Miller <admiller@redhat.com> Signed-off-by: Adam Miller <admiller@redhat.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adam Miller admiller@redhat.com
SUMMARY
This appears to achieve roughly a 1 minute per student environment
speed increase which can be rather impactful for larger workshops
(AnsibleFest notably).
Before this patchset with 10 students
real 39m48.828s
user 5m52.074s
sys 1m19.715s
After this patchset with 10 students
real 31m13.664s
user 4m29.428s
sys 1m25.586s
Before this patchset with 20 students
real 65m3.124s
user 9m9.207s
sys 2m25.135s
After this patchset with 20 students
real 45m13.722s
user 8m31.238s
sys 2m29.468s
For posterity, I did run Roland's verifier playbook against the
provisioned environment that results from these changes to ensure
sanity checking and the verifier playbook was successful.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
There are other changes I'd like to make, as well as others that Roland has planned, that will continue to significantly speed the provision of the security workshop up to make but they are outside the scope of this particular change set.