Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed hook var names to not conflict when used with deploy role #21

Merged
merged 3 commits into from
Oct 30, 2018

Conversation

mlvnds
Copy link
Contributor

@mlvnds mlvnds commented Sep 10, 2018

When the same vars file is shared across ansistrano deploy and rollback roles, custom task files variables conflict. This comportment force Ansible to only use value of te last declaration of custom task file.

@ricardclau
Copy link
Member

Mmm you are right... I guess most people define these in the playbook itself and not using group_vars or a common vars file.

It can be sorted out with 2 vars files of course but it is not ideal. Not great to break BC for everyone either :)

Can you please rebase latest changes while we consider this?

@ricardclau
Copy link
Member

You should keep the include_tasks syntax instead of the old include one

@ricardclau
Copy link
Member

Thanks for this contribution! Will add a validation step so that it fails with the old syntax and release a 3.0 version

@ricardclau ricardclau merged commit d44eb13 into ansistrano:master Oct 30, 2018
@ricardclau
Copy link
Member

Oh no, I cannot make a fail message as it will fail in your case... well will add some big notes in the readme and release notes

@mlvnds mlvnds deleted the feat/roleBasedVariables branch December 13, 2018 14:38
mcritchlow added a commit to ucsdlib/theodor that referenced this pull request Jan 28, 2019
mcritchlow added a commit to ucsdlib/theodor that referenced this pull request Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants