Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain the sphinx design #162

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Maintain the sphinx design #162

merged 1 commit into from
Nov 28, 2022

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Nov 28, 2022 •
edited
Loading

Before patch,

  • add fading around the cards on dark theme
  • make the cards are of same size irrespective of text size

@github-actions github-actions bot added the maintenance Generic maintenance related label Nov 28, 2022
@jorgepiloto
Copy link
Member

Just to make sure, this pull-request allows to display some fading light around the cards, right?

@Revathyvenugopal162
Copy link
Contributor Author

Just to make sure, this pull-request allows to display some fading light around the cards, right?

yes and also the cards are in same size, irrespective of the text inside.

@Revathyvenugopal162 Revathyvenugopal162 merged commit 78c28a7 into main Nov 28, 2022
@Revathyvenugopal162 Revathyvenugopal162 deleted the maint/sphinx-design-styles branch November 28, 2022 09:41
Revathyvenugopal162 added a commit that referenced this pull request Nov 28, 2022
@Revathyvenugopal162
Maintain the sphinx design (#162)
0d6df35
@MaxJPRey
Copy link
Contributor

Very nice improvement @Revathyvenugopal162 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@MaxJPRey MaxJPRey Awaiting requested review from MaxJPRey

Assignees
No one assigned
Labels
maintenance Generic maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Revathyvenugopal162 @jorgepiloto @MaxJPRey