Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI - Minor script fixes #337

Merged
merged 2 commits into from
Aug 17, 2023
Merged

CI - Minor script fixes #337

merged 2 commits into from
Aug 17, 2023

Conversation

da1910
Copy link
Collaborator

@da1910 da1910 commented Aug 17, 2023

Couple of minor fixes:

  1. Fix name of database in modify_custom_rs_db.py - we don't fetch tables after renaming, so we need the old name
  2. Only use history GUID to avoid issues with new versions

ludovicsteinbach
ludovicsteinbach approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@ludovicsteinbach ludovicsteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da1910 da1910 added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit a52e39a Aug 17, 2023
@ludovicsteinbach ludovicsteinbach deleted the ci/update_records branch January 17, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovicsteinbach ludovicsteinbach ludovicsteinbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@da1910 @ludovicsteinbach