347 - Use regex to replace server URL #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 10 10
Lines 1386 1386
=======================================
Hits 1320 1320
Misses 66 66 |
Andy-Grigg
commented
Aug 25, 2023
| @@ -30,12 +31,20 @@ def with_autologon(self: Connection) -> Connection: | |||
| Connection.with_autologon = with_autologon | |||
|
|
|||
|
|
|||
| # Monkey patch the Client object to report the url specified in the code, or the one below if not overridden | |||
| # Monkey patch the Client object to report the url specified below | |||
There was a problem hiding this comment.
I can't see where this would be overridden, so I changed the comment
da1910
approved these changes
Aug 28, 2023
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #347
Use a regular expression to replace the URL in the BomAnalyticsClient repr. Raise a ValueError if no match is found.