Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Check for active runs before stopping VM #478

Merged
merged 14 commits into from
Apr 16, 2024

Conversation

ludovicsteinbach
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the maintenance Package and maintenance related label Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (60edd35) to head (2e45013).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          18       18           
  Lines        2434     2434           
=======================================
  Hits         2369     2369           
  Misses         65       65           
Flag Coverage Δ
integration 82.49% <ø> (ø)
unittests 96.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ludovicsteinbach
Copy link
Contributor Author

@ludovicsteinbach ludovicsteinbach requested a review from da1910 April 16, 2024 09:20
Copy link
Collaborator

@da1910 da1910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, I wish there were a way to get the list from somewhere central, like the pygranta repository but this is fine for the moment

@ludovicsteinbach ludovicsteinbach added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 54016da Apr 16, 2024
29 checks passed
@ludovicsteinbach ludovicsteinbach deleted the ci/skip-vm-management-if-active-runs branch April 16, 2024 09:44
@Andy-Grigg Andy-Grigg mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants