Empty elements are no longer removed when deserializing a BoM file #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andy-Grigg
commented
May 31, 2024
| @@ -80,33 +86,54 @@ def _compare_boms(*, source_bom: str, result_bom: str): | |||
| output_lines.append(diff_item) | |||
| return output_lines | |||
|
|
|||
| def test_roundtrip_from_text_with_assertions(self): | |||
There was a problem hiding this comment.
The diff here is garbled. I basically duplicated the two existing tests, but passing in a path instead of a string
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
+ Coverage 97.43% 97.63% +0.19%
==========================================
Files 18 18
Lines 2539 2542 +3
==========================================
+ Hits 2474 2482 +8
+ Misses 65 60 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
da1910
approved these changes
Jun 3, 2024
The new behavior is the converse, we keep empty elements in all cases, so as to be compliant with the schema. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #545
Standardizes the options used when deserializing a BoM from a file and from a string. Previously,
keep_empty=Truewas only specified when reading a BoM from string, which caused a weird asymmetry in some situations.This PR removes this duplication, and adds some tests that check deserializing and round-tripping a BoM with an empty element works both via a file and via text.