Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Trap topology condition update for multiband filters #5266

Merged

Conversation

ramin4667
Copy link
Collaborator

This PR updates the Trap topology condition to accept multiple band filters.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (48c59c4) to head (d886ab0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5266      +/-   ##
==========================================
- Coverage   83.27%   83.25%   -0.03%     
==========================================
  Files         143      143              
  Lines       58439    58442       +3     
==========================================
- Hits        48666    48656      -10     
- Misses       9773     9786      +13     

@ramin4667 ramin4667 changed the title FIX: Clear function added to multipleband table FIX: Trap topology condition update for multiband filters Oct 8, 2024
Copy link
Collaborator

@myoung301 myoung301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@myoung301 myoung301 merged commit 4a894a0 into main Oct 8, 2024
42 checks passed
@myoung301 myoung301 deleted the FIX__Trap_topology_condition_update_for_multiband_filters branch October 8, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants