Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Close on exit unless asked not to #5292

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

When adding the action of closing AEDT through atexit.register, the case with close_on_exit=False was not handled.
This should fix this behavior.

Close #5273

@AlfVII Can you give a try at this PR to see if it fixes your problem ?

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@AlfVII
Copy link
Contributor

AlfVII commented Oct 14, 2024

Works :)

Copy link
Contributor

@AlfVII AlfVII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes my issue :)

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) October 14, 2024 11:34
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (7e793f9) to head (d6a5a34).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5292   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files         143      143           
  Lines       58471    58471           
=======================================
  Hits        48683    48683           
  Misses       9788     9788           

@Samuelopez-ansys Samuelopez-ansys merged commit 71d63c7 into main Oct 14, 2024
41 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/not-always-register-close-on-exit branch October 14, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug that releases and closes the Desktop, even with "close_on_exit=False"
3 participants