Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow picking from easy access methods #1499

Merged
merged 11 commits into from
Oct 24, 2024

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Oct 21, 2024

Description

Allow picking directly from component or body... this requires modifications in visualization tool.

Issue linked

Closes #1498

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Oct 21, 2024
@RobPasMue RobPasMue linked an issue Oct 21, 2024 that may be closed by this pull request
@github-actions github-actions bot added the enhancement New features or code improvements label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.65%. Comparing base (c4c4d14) to head (d71885f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/plotting/plotter.py 20.00% 8 Missing ⚠️
src/ansys/geometry/core/designer/component.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
- Coverage   91.78%   91.65%   -0.13%     
==========================================
  Files          86       86              
  Lines        6974     6986      +12     
==========================================
+ Hits         6401     6403       +2     
- Misses        573      583      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the maintenance Package and maintenance related label Oct 23, 2024
@github-actions github-actions bot removed the maintenance Package and maintenance related label Oct 24, 2024
@RobPasMue RobPasMue marked this pull request as ready for review October 24, 2024 06:47
@RobPasMue RobPasMue requested a review from a team as a code owner October 24, 2024 06:47
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just a small consideration, is the picker example still up to date after these changes? I assume that it is but just in case 🙂

https://geometry.docs.pyansys.com/version/stable/examples/01_getting_started/05_plotter_picker.html#Select-objects-interactively

@RobPasMue
Copy link
Member Author

Just a small consideration, is the picker example still up to date after these changes? I assume that it is but just in case 🙂

Good point - I also included in the docs the fact that a user could now just say design.plot(allow_picking=True) if they wanted. Also, the example was working fine buuuut... only for Windows. The Linux service was crashing since it does not allow for multiple designs, so I had to change the location of the multi_colors section. Thanks @AlejandroFernandezLuces for the review!

@RobPasMue RobPasMue enabled auto-merge (squash) October 24, 2024 07:35
@RobPasMue RobPasMue merged commit 85e5df3 into main Oct 24, 2024
37 of 39 checks passed
@RobPasMue RobPasMue deleted the feat/allow-picking-from-easy-access-methods branch October 24, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for picking directly from component level
3 participants