Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create launcher for core services #1587

Merged
merged 21 commits into from
Dec 19, 2024
Merged

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Dec 16, 2024

Description

Provide a launching mechanism for Core Services. Should work both on Windows and Linux

Issue linked

Closes #1578

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Dec 16, 2024
@RobPasMue RobPasMue self-assigned this Dec 17, 2024
@RobPasMue RobPasMue marked this pull request as ready for review December 17, 2024 13:30
@RobPasMue RobPasMue requested a review from a team as a code owner December 17, 2024 13:30
@RobPasMue
Copy link
Member Author

RobPasMue commented Dec 17, 2024

IMPORTANT NOTE - when using ansys-tools-path on Linux (and consequently, the launcher function), it is important that the Geometry Core Service is located in one of the following directories:

  • /usr/ansys_inc/vXXX/CoreGeometryService
  • /install/ansys_inc/vXXX/CoreGeometryService
  • /ansys_inc/vXXX/CoreGeometryService

Feel free to use symbolic links to try this out.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 49.12281% with 29 lines in your changes missing coverage. Please review.

Project coverage is 91.28%. Comparing base (9bca5e1) to head (a6c9d66).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ansys/geometry/core/connection/product_instance.py 21.21% 26 Missing ⚠️
src/ansys/geometry/core/connection/launcher.py 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1587      +/-   ##
==========================================
- Coverage   91.61%   91.28%   -0.34%     
==========================================
  Files          86       86              
  Lines        7064     7104      +40     
==========================================
+ Hits         6472     6485      +13     
- Misses        592      619      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MaxJPRey
MaxJPRey previously approved these changes Dec 17, 2024
@RobPasMue
Copy link
Member Author

Let's merge this one as is. Testing for launching local products is not in yet anyway (our VMs rely on Docker). We can come back to fix things.

@RobPasMue RobPasMue enabled auto-merge (squash) December 19, 2024 08:28
@RobPasMue RobPasMue merged commit dc6f03e into main Dec 19, 2024
45 of 47 checks passed
@RobPasMue RobPasMue deleted the feat/launcher-for-core-services branch December 19, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local launcher method for core services
4 participants