feat: bounded geometry #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dastan-ansys
commented
Aug 15, 2023
dastan-ansys
commented
- Added client-side implementation for trimmed surfaces, trimmed curves, as well as taking into account their reverse direction.
- Implemented the plane surface type and box uv for trimmed surfaces.
github-actions
bot
added
testing
…geometry into feat/bounded-geometry
|
@jonahrb... this PR has a lot of conflicts IMO, it might take a while to bring it back to life 😄 |
for more information, see https://pre-commit.ci
…sys-geometry into feat/bounded-geometry
PipKat
reviewed
Mar 4, 2024
PipKat
reviewed
Mar 4, 2024
PipKat
reviewed
Mar 4, 2024
PipKat
reviewed
Mar 4, 2024
PipKat
reviewed
Mar 4, 2024
9 tasks
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
…geometry into feat/bounded-geometry
… example notebook 1
|
Thanks a lot @dastan-ansys - let me start reviewing right away |
RobPasMue
reviewed
Mar 12, 2024
There was a problem hiding this comment.
Tremendous work @dastan-ansys - it looks great to me. I'd merge it as is. But we might have to follow up with whatever sections are untested. We will be able to see what things remain untested and we will have to add unit tests for them. Nonetheless - I'd suggest we merge it right away
RobPasMue
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.